Remove xfs-progs blob from release #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkfs.xfs is present on the stemcell (jammy) as a pacakge already. It's not clear why we need this blob and why we compile an older version while grootfs is using the newer version when running outside of overlay-xfs-setup.
- autoconf - automake - libtool - lzo - util-linux - zlib
winkingturtle-vmw
force-pushed
the
remove-xfs-progs-package
branch
from
77227bd
to
88f5ff2
Compare
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkfs.xfs is present on the stemcell (jammy) as a pacakge already. It's not clear why we need this blob and why we compile an older version (4.20.0) while grootfs is using the newer version (5.13.0) when running outside of overlay-xfs-setup. I was able to deploy this branch and start an app.
If this is related to a version of the stemcell, we should make sure that the code is running the intended version instead of using mkfs.xfs that is on the path.
If we were to merge this pr, the follow list of blobs and packages seems to be unused and can also be removed: